Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(erc20,tests): add tests for ERC20 precompile events #1984

Merged
merged 11 commits into from
Nov 2, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR adds tests to the ERC20 precompile event emitting.


Closes ENG-2282

@MalteHerrmann MalteHerrmann requested a review from a team as a code owner November 2, 2023 14:39
@MalteHerrmann MalteHerrmann requested review from facs95 and GAtom22 and removed request for a team November 2, 2023 14:39
Copy link

linear bot commented Nov 2, 2023

ENG-2282 Add ERC20 events unit tests

Add unit tests for the events added in PR #1982

precompiles/erc20/events.go Outdated Show resolved Hide resolved
precompiles/erc20/events_test.go Show resolved Hide resolved
precompiles/erc20/events_test.go Show resolved Hide resolved
precompiles/erc20/events_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1984 (ffd7b67) into main (ab74c9e) will decrease coverage by 0.36%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head ffd7b67 differs from pull request most recent head 6d7b866. Consider uploading reports for the commit 6d7b866 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   69.97%   69.62%   -0.36%     
==========================================
  Files         327      330       +3     
  Lines       24270    24477     +207     
==========================================
+ Hits        16984    17042      +58     
- Misses       6415     6557     +142     
- Partials      871      878       +7     
Files Coverage Δ
precompiles/erc20/erc20.go 17.58% <ø> (ø)
precompiles/erc20/types.go 0.00% <ø> (ø)
precompiles/common/abi.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

precompiles/erc20/setup_test.go Outdated Show resolved Hide resolved
precompiles/erc20/events_test.go Outdated Show resolved Hide resolved
@MalteHerrmann MalteHerrmann enabled auto-merge (squash) November 2, 2023 16:07
@MalteHerrmann MalteHerrmann merged commit b826687 into main Nov 2, 2023
27 of 28 checks passed
@MalteHerrmann MalteHerrmann deleted the malte/add-erc20events-tests branch November 2, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants