fix(test): fix the problem about deliverTxSimulate in test app/ante/cosmos/min_price_test.go #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osmos/min_price_test.go
luchenqun
requested review from
MalteHerrmann and
GAtom22
and removed request for
a team
GAtom22
approved these changes
Nov 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #1989 +/- ##
==========================================
+ Coverage 69.49% 69.72% +0.22%
==========================================
Files 332 331 -1
Lines 24618 24537 -81
==========================================
Hits 17108 17108
+ Misses 6626 6545 -81
Partials 884 884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I saw some tests in it, deliverTx can pass, but deliverTxSimulate cannot. This is obviously wrong. Because the former has stricter inspections than the latter