Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(erc20,tests): add erc20 types tests #1994

Merged
merged 11 commits into from Nov 3, 2023
Merged

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR adds unit tests for the utilities regarding the ERC20 precompile types.


Closes ENG-2283

Copy link

linear bot commented Nov 3, 2023

ENG-2283 Add ERC20 types unit tests

Add tests for the functions defined in precompile/erc20/types.go

@MalteHerrmann MalteHerrmann marked this pull request as ready for review November 3, 2023 10:43
@MalteHerrmann MalteHerrmann requested a review from a team as a code owner November 3, 2023 10:43
@MalteHerrmann MalteHerrmann requested review from 0xstepit and GAtom22 and removed request for a team November 3, 2023 10:43
@fedekunze fedekunze enabled auto-merge (squash) November 3, 2023 10:44
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1994 (815b051) into main (342d9c8) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
+ Coverage   69.49%   69.75%   +0.26%     
==========================================
  Files         332      332              
  Lines       24618    24618              
==========================================
+ Hits        17108    17173      +65     
+ Misses       6626     6561      -65     
  Partials      884      884              

see 1 file with indirect coverage changes

@MalteHerrmann MalteHerrmann marked this pull request as draft November 3, 2023 12:02
@MalteHerrmann MalteHerrmann marked this pull request as ready for review November 3, 2023 13:09
@fedekunze fedekunze merged commit 89b3b81 into main Nov 3, 2023
32 of 33 checks passed
@fedekunze fedekunze deleted the malte/add-erc20-types-tests branch November 3, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants