New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(erc20): ERC-20 approval #1995
Conversation
} | ||
|
||
// get allowance and ignore the error as it will be checked in the switch statement below | ||
allowance, _ := GetAllowance(p.AuthzKeeper, ctx, grantee, granter, p.tokenPair.Denom) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
Codecov Report
@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
- Coverage 69.65% 69.17% -0.48%
==========================================
Files 333 334 +1
Lines 24656 24824 +168
==========================================
Hits 17173 17173
- Misses 6599 6767 +168
Partials 884 884
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
Description
Closes #XXX