New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(erc20): add erc20 extension approval tests #2005
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
+ Coverage 69.14% 69.71% +0.56%
==========================================
Files 334 334
Lines 24837 24830 -7
==========================================
+ Hits 17173 17309 +136
+ Misses 6780 6627 -153
- Partials 884 894 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Pending the open questions regarding authorization handling of denoms and deleting on 0 limit left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good findings @MalteHerrmann! left some comments
After discussion the open points and adjustments will be handled on a follow-up PR to make reviews cleaner. |
Description
This PR adds unit tests for the ERC20 extension approvals.
Additionally, some authorization related methods were added to the integration test utils.
Closes ENG-2285