chore: add cmds for rocks and pebble builds #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-2286 Add rocksdb build for evmos Dockerfile
ContextDevops team wants to explore the possibility to use versionDB for archive nodes. For this to be possible, we need to provide them with a docker image that has the evmosd binary compiled with rocksdb ExpectedProvide a docker image of the evmosd binary compiled with librocksd |
…vmos into GAtom22/dockerfile-rocks
GAtom22
changed the title
GAtom22
changed the title
GAtom22
requested review from
Vvaradinov and
0xstepit
and removed request for
a team
Aminechakr
reviewed
Nov 10, 2023
MalteHerrmann
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Unfortunately RocksDB build is not working for MacOS - not sure if that's really required since most node operators will use Linux I'm assuming, but I couldn't verify this works.
../../../../go/pkg/mod/github.com/linx!gnu/grocksdb@v1.8.5/array.go:4:11: fatal error: 'rocksdb/c.h' file not found
#include "rocksdb/c.h"
^~~~~~~~~~~~~
1 error generated.
make[1]: *** [build] Error 1
make: *** [build-rocksdb] Error 2
PebbleDB works fine 👍
MalteHerrmann
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes ENG-2286