Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(erc20): add transaction unit tests #2009

Merged
merged 5 commits into from Nov 7, 2023

Conversation

Vvaradinov
Copy link
Contributor

Description

This PR adds transaction unit tests for the erc20 precompile.


Closes ENG-2287

@Vvaradinov Vvaradinov requested a review from a team as a code owner November 7, 2023 13:07
@Vvaradinov Vvaradinov requested review from facs95 and 0xstepit and removed request for a team November 7, 2023 13:07
Copy link

linear bot commented Nov 7, 2023

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2009 (283dc17) into main (fbf3d82) will increase coverage by 0.69%.
Report is 1 commits behind head on main.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
+ Coverage   69.14%   69.83%   +0.69%     
==========================================
  Files         334      334              
  Lines       24837    24830       -7     
==========================================
+ Hits        17173    17341     +168     
+ Misses       6780     6593     -187     
- Partials      884      896      +12     
Files Coverage Δ
precompiles/erc20/approve.go 82.46% <100.00%> (+82.46%) ⬆️
precompiles/erc20/tx.go 84.21% <100.00%> (+84.21%) ⬆️
precompiles/erc20/query.go 8.49% <60.00%> (+8.49%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit 0a5bdc1 into main Nov 7, 2023
33 of 34 checks passed
@fedekunze fedekunze deleted the Vvaradinov/erc20-tx-unit-tests branch November 7, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants