Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(erc20): add erc20 query tests #2023

Merged
merged 28 commits into from Nov 9, 2023
Merged

Conversation

MalteHerrmann
Copy link
Contributor

Description

This PR adds unit tests for the ERC20 precompile queries. There are some minor adjustments to the implementation resulting from the testing.


Closes ENG-2288

Copy link

linear bot commented Nov 9, 2023

Copy link
Contributor Author

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments / open questions here 👇

precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query.go Show resolved Hide resolved
precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/utils_test.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2023 (51a81b2) into main (377bfd9) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
+ Coverage   69.91%   70.30%   +0.38%     
==========================================
  Files         334      334              
  Lines       24977    24990      +13     
==========================================
+ Hits        17462    17568     +106     
+ Misses       6611     6518      -93     
  Partials      904      904              
Files Coverage Δ
precompiles/erc20/query.go 96.63% <100.00%> (+88.14%) ⬆️

Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @MalteHerrmann !!!

precompiles/erc20/query.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
precompiles/erc20/query_test.go Outdated Show resolved Hide resolved
@MalteHerrmann MalteHerrmann marked this pull request as ready for review November 9, 2023 17:05
@MalteHerrmann MalteHerrmann requested a review from a team as a code owner November 9, 2023 17:05
@MalteHerrmann MalteHerrmann requested review from Vvaradinov and GAtom22 and removed request for a team November 9, 2023 17:05
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@fedekunze fedekunze merged commit 0add6e8 into main Nov 9, 2023
34 of 35 checks passed
@fedekunze fedekunze deleted the malte/add-erc20-query-tests branch November 9, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants