New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(osmosis-outpost): use wrapper structure for parsed Swap inputs #2025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## main #2025 +/- ##
==========================================
+ Coverage 69.87% 69.91% +0.03%
==========================================
Files 334 334
Lines 24946 24978 +32
==========================================
+ Hits 17431 17463 +32
Misses 6611 6611
Partials 904 904
|
Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
Description
This PR is a followup of the Osmosis outpost implementing a suggestion from @facs95 . The arguments from the Solidity side are now wrapped into a structure. This will:
make the code more readable
make the code more maintainable
avoiding polyadic functions.
Closes #XXX