Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(osmosis-outpost): use wrapper structure for parsed Swap inputs #2025

Merged
merged 7 commits into from Nov 9, 2023

Conversation

0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Nov 9, 2023

Description

This PR is a followup of the Osmosis outpost implementing a suggestion from @facs95 . The arguments from the Solidity side are now wrapped into a structure. This will:

make the code more readable
make the code more maintainable
avoiding polyadic functions.


Closes #XXX

@0xstepit 0xstepit marked this pull request as ready for review November 9, 2023 12:01
@0xstepit 0xstepit requested a review from a team as a code owner November 9, 2023 12:01
@0xstepit 0xstepit requested review from Vvaradinov and GAtom22 and removed request for a team November 9, 2023 12:01
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

precompiles/outposts/osmosis/types.go Show resolved Hide resolved
precompiles/outposts/osmosis/types.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2025 (2dff188) into main (e58621a) will increase coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 95.74%.

❗ Current head 2dff188 differs from pull request most recent head fd1ca1f. Consider uploading reports for the commit fd1ca1f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
+ Coverage   69.87%   69.91%   +0.03%     
==========================================
  Files         334      334              
  Lines       24946    24978      +32     
==========================================
+ Hits        17431    17463      +32     
  Misses       6611     6611              
  Partials      904      904              
Files Coverage Δ
precompiles/outposts/osmosis/tx.go 87.87% <100.00%> (+3.46%) ⬆️
precompiles/outposts/osmosis/types.go 92.03% <92.00%> (+0.77%) ⬆️

0xstepit and others added 2 commits November 9, 2023 16:10
@0xstepit 0xstepit enabled auto-merge (squash) November 9, 2023 15:15
@0xstepit 0xstepit merged commit 377bfd9 into main Nov 9, 2023
27 checks passed
@0xstepit 0xstepit deleted the stepit/osmosis-struct-wrapper branch November 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants