Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bech32): Port bech32 extension #2038

Merged
merged 11 commits into from Nov 15, 2023
Merged

Conversation

Vvaradinov
Copy link
Contributor

Description


This PR ports the bech32 precompile over and initializes it, adding it to our AvailableEVMExtensions. Test coverage for the precompile is >90%.

Closes #XXX

@Vvaradinov Vvaradinov requested a review from a team as a code owner November 14, 2023 10:07
@Vvaradinov Vvaradinov requested review from facs95 and 0xstepit and removed request for a team November 14, 2023 10:07
precompiles/bech32/methods.go Dismissed Show dismissed Hide dismissed
precompiles/bech32/bech32.go Dismissed Show dismissed Hide dismissed
@0xstepit
Copy link
Contributor

Please add the CHANGELOG entry

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments re setup and license

precompiles/bech32/Bech32.sol Show resolved Hide resolved
precompiles/bech32/setup_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Vvaradinov !

@Vvaradinov Vvaradinov enabled auto-merge (squash) November 14, 2023 15:44
@fedekunze
Copy link
Contributor

merging as the error seems unrelated

@fedekunze fedekunze merged commit 2d66645 into main Nov 15, 2023
30 of 31 checks passed
@fedekunze fedekunze deleted the Vvaradinov/port-bech32-precompile branch November 15, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants