-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(staking): add CreateValidator unit test for precompiled contract staking #2050
Conversation
I need some time to study your relevant precompile contract test code and then complete the tests. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
+ Coverage 70.06% 70.44% +0.38%
==========================================
Files 340 340
Lines 25492 25492
==========================================
+ Hits 17861 17959 +98
+ Misses 6713 6609 -104
- Partials 918 924 +6
|
@fedekunze @Vvaradinov You can start review the code for me now. If there are any missing unit tests or improvements that need to be made, please tell me in the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, great work! Left two suggestions for the tests, but looks good 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @luchenqun and thanks for your contribution!
Description
add CreateValidator unit test for precompiled contract staking, for more details see related #2030