Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(staking): add CreateValidator unit test for precompiled contract staking #2050

Merged
merged 11 commits into from
Nov 22, 2023

Conversation

luchenqun
Copy link
Contributor

@luchenqun luchenqun commented Nov 17, 2023

Description

add CreateValidator unit test for precompiled contract staking, for more details see related #2030

@luchenqun luchenqun requested a review from a team as a code owner November 17, 2023 01:05
@luchenqun luchenqun requested review from 0xstepit and GAtom22 and removed request for a team November 17, 2023 01:05
@luchenqun
Copy link
Contributor Author

luchenqun commented Nov 17, 2023

I need some time to study your relevant precompile contract test code and then complete the tests.

@luchenqun luchenqun changed the title imp(staking): added CreateValidator unit test for precompiled contract Staking imp(staking): add CreateValidator unit test for precompiled contract staking Nov 17, 2023
@luchenqun luchenqun marked this pull request as draft November 17, 2023 01:10
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #2050 (2527533) into main (6b89f64) will increase coverage by 0.38%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 2527533 differs from pull request most recent head 8a560f3. Consider uploading reports for the commit 8a560f3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
+ Coverage   70.06%   70.44%   +0.38%     
==========================================
  Files         340      340              
  Lines       25492    25492              
==========================================
+ Hits        17861    17959      +98     
+ Misses       6713     6609     -104     
- Partials      918      924       +6     
Files Coverage Δ
precompiles/staking/events.go 71.10% <ø> (+7.79%) ⬆️
precompiles/staking/types.go 88.35% <ø> (+13.47%) ⬆️

... and 1 file with indirect coverage changes

@luchenqun luchenqun marked this pull request as ready for review November 18, 2023 14:01
@luchenqun
Copy link
Contributor Author

luchenqun commented Nov 18, 2023

@fedekunze @Vvaradinov You can start review the code for me now. If there are any missing unit tests or improvements that need to be made, please tell me in the comments.

Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, great work! Left two suggestions for the tests, but looks good 🙏

precompiles/staking/tx_test.go Outdated Show resolved Hide resolved
precompiles/staking/tx_test.go Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @luchenqun and thanks for your contribution!

@fedekunze fedekunze enabled auto-merge (squash) November 22, 2023 15:06
@fedekunze fedekunze merged commit 6e2812d into evmos:main Nov 22, 2023
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants