Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(distribution): change the validator address in the events from string type to address type #2055

Merged
merged 3 commits into from Nov 21, 2023

Conversation

luchenqun
Copy link
Contributor

Description

See #2053

@luchenqun luchenqun requested a review from a team as a code owner November 19, 2023 13:13
@luchenqun luchenqun requested review from Vvaradinov and GAtom22 and removed request for a team November 19, 2023 13:13
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #2055 (298aa73) into main (6befcc6) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
- Coverage   70.17%   70.16%   -0.01%     
==========================================
  Files         340      340              
  Lines       25452    25454       +2     
==========================================
- Hits        17862    17861       -1     
- Misses       6673     6675       +2     
- Partials      917      918       +1     
Files Coverage Δ
precompiles/distribution/types.go 92.78% <ø> (ø)
precompiles/distribution/events.go 77.77% <40.00%> (-2.42%) ⬇️

@fedekunze fedekunze enabled auto-merge (squash) November 20, 2023 14:35
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

@fedekunze fedekunze merged commit 4a1b3f5 into evmos:main Nov 21, 2023
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants