Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(incentives): remove incentives mod & burn incentives pool #2070

Merged
merged 26 commits into from Nov 29, 2023
Merged

imp(incentives): remove incentives mod & burn incentives pool #2070

merged 26 commits into from Nov 29, 2023

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Nov 23, 2023 •
edited by GAtom22

Description

Closes ENG-2338

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited

Codecov Report

Merging #2070 (4694b90) into main (323b733) will increase coverage by 0.13%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 4694b90 differs from pull request most recent head 786b279. Consider uploading reports for the commit 786b279 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
+ Coverage   70.27%   70.40%   +0.13%     
==========================================
  Files         339      344       +5     
  Lines       25538    25645     +107     
==========================================
+ Hits        17946    18055     +109     
- Misses       6654     6656       +2     
+ Partials      938      934       -4
Files Coverage Δ
app/app.go 81.06% <100.00%> (+0.91%) ⬆️

... and 50 files with indirect coverage changes

@GAtom22 GAtom22 changed the title imp(incentives): burn incentives pool and disable logic imp(incentives): remove incentives mod & burn incentives pool and disable logic Nov 27, 2023
@GAtom22 GAtom22 changed the title imp(incentives): remove incentives mod & burn incentives pool and disable logic imp(incentives): remove incentives mod & burn incentives pool Nov 27, 2023
@github-actions github-actions bot added the tests label Nov 27, 2023
@linear Linear
Copy link

linear bot commented Nov 27, 2023

ENG-2338 Remove incentives module

Context

Expected

@fedekunze fedekunze marked this pull request as ready for review November 28, 2023 11:43
@fedekunze fedekunze requested a review from a team as a code owner November 28, 2023 11:43
@fedekunze fedekunze requested review from Vvaradinov and MalteHerrmann and removed request for a team November 28, 2023 11:43
MalteHerrmann
MalteHerrmann approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 👏 left some minor comments

app/upgrades/v16/incentives.go Outdated Show resolved Hide resolved
app/upgrades/v16/incentives.go Outdated Show resolved Hide resolved
app/upgrades/v16/upgrades.go Outdated Show resolved Hide resolved
proto/evmos/inflation/v1/inflation.proto Outdated Show resolved Hide resolved
x/inflation/v1/keeper/integration_test.go Show resolved Hide resolved
x/inflation/v1/keeper/integration_test.go Show resolved Hide resolved
GAtom22 and others added 5 commits November 28, 2023 17:24
@GAtom22
add tests
c0d9a9f
@GAtom22
update upgrade logic and permissions
63c92f2
@GAtom22
Merge branch 'fedekunze/inf-pool' of https://github.com/evmos/evmos i…
6eb8fb1 
…nto fedekunze/inf-pool
@GAtom22 @MalteHerrmann
Apply suggestions from code review
ee2b614 
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
@GAtom22 @MalteHerrmann
Update x/inflation/v1/keeper/integration_test.go
88fd190 
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
@fedekunze fedekunze enabled auto-merge (squash) November 29, 2023 08:40
@fedekunze fedekunze merged commit 6c63a83 into main Nov 29, 2023
30 of 32 checks passed
@fedekunze fedekunze deleted the fedekunze/inf-pool branch November 29, 2023 11:30
@luchenqun luchenqun mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalteHerrmann MalteHerrmann MalteHerrmann approved these changes

@GAtom22 GAtom22 GAtom22 left review comments

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
CLI proto tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fedekunze @MalteHerrmann @GAtom22