fix(db): change versiondb directory permission from 777 (insecure) to 750 (general) #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorTrustyDev
requested review from
facs95 and
MalteHerrmann
and removed request for
a team
VictorTrustyDev
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 344 344
Lines 25642 25642
=======================================
Hits 18052 18052
Misses 6656 6656
Partials 934 934
|
fedekunze
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
versiondbdirectory was created with permissionos.ModePerm(777) which is insecure so I changed it to generic permission 750.In additional, I rename some wrong variable name which pointed out in #2058