imp(erc20): align metadata query errors with ERC20 contracts #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
requested review from
facs95 and
0xstepit
and removed request for
a team
MalteHerrmann
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
+ Coverage 70.40% 70.41% +0.01%
==========================================
Files 344 344
Lines 25642 25651 +9
==========================================
+ Hits 18052 18063 +11
+ Misses 6656 6654 -2
Partials 934 934
|
fedekunze
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ies implemented
Description
This PR aligns the response from failing metadata queries with the ERC20 contracts which don't expose their metadata. These return the general "execution reverted" error with no further info, which is what we've implemented here.