imp(ante): depecrate legacy EIP712 ante handler #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facs95
requested review from
Vvaradinov and
MalteHerrmann
and removed request for
a team
facs95
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
==========================================
+ Coverage 70.17% 70.23% +0.05%
==========================================
Files 353 353
Lines 25948 25919 -29
==========================================
- Hits 18210 18205 -5
+ Misses 6792 6768 -24
Partials 946 946
|
fedekunze
approved these changes
Nov 27, 2023
|
@facs95 can you fix the conflicts 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the effort of the ante handler refractor, it seems like a good time to deprecate the legacy EIP712 handler
Closes #XXX