Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove recovery module #2087

Merged
merged 3 commits into from
Nov 27, 2023
Merged

chore: remove recovery module #2087

merged 3 commits into from
Nov 27, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Nov 27, 2023

Description

Closes #XXX

@GAtom22 GAtom22 marked this pull request as ready for review November 27, 2023 17:38
@GAtom22 GAtom22 requested a review from a team as a code owner November 27, 2023 17:38
@GAtom22 GAtom22 requested review from Vvaradinov and MalteHerrmann and removed request for a team November 27, 2023 17:38
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2087 (fd9b493) into main (651f2a1) will decrease coverage by 0.17%.
Report is 1 commits behind head on main.
The diff coverage is 25.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
- Coverage   70.23%   70.06%   -0.17%     
==========================================
  Files         353      339      -14     
  Lines       25919    25499     -420     
==========================================
- Hits        18205    17867     -338     
+ Misses       6768     6697      -71     
+ Partials      946      935      -11
Files Coverage Δ
app/keys.go 100.00% <100.00%> (ø)
app/app.go 80.13% <14.28%> (-0.87%) ⬇️

fedekunze
fedekunze approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit f909c22 into main Nov 27, 2023
33 of 38 checks passed
@fedekunze fedekunze deleted the GAtom22/deprecate-mods branch November 27, 2023 18:39
@damiannolan damiannolan mentioned this pull request Nov 29, 2023
Merged
9 tasks
@luchenqun luchenqun mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
CLI proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GAtom22 @fedekunze