imp(erc20): Adjust ERC20 allowance behavior for same spender #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
requested review from
0xstepit and
GAtom22
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
==========================================
+ Coverage 70.14% 70.27% +0.12%
==========================================
Files 339 339
Lines 25499 25538 +39
==========================================
+ Hits 17887 17946 +59
+ Misses 6675 6654 -21
- Partials 937 938 +1
|
GAtom22
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the behavior of the ERC20 EVM extension in the following way:
abi.MaxUint256(infinite allowance)transferFromwhere the owner is the spender will work without need for an approval and always emit anApprovalEventwith the new allowance beingabi.MaxUint256.This behavior differs from the standard ERC20 OpenZeppelin contracts, but is not otherwise possible without changes to the Cosmos SDK. Here, grants between the same granter and grantee are not supported.
Since an allowance for oneself is completely useless, this will not inhibit any user stories and should be at most a minor inconvenience for users.