chore: refactor to use cosmossdk/math types #2104
Merged
+1,734
−1,706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -442,7 +443,7 @@ | |||
| return nil, errorsmod.Wrapf(types.ErrGasOverflow, "message gas limit < leftover gas (%d < %d)", msg.Gas(), leftoverGas) | |||
| } | |||
|
|
|||
| gasUsed := sdk.MaxDec(minimumGasUsed, sdk.NewDec(int64(temporaryGasUsed))).TruncateInt().Uint64() | |||
| gasUsed := math.LegacyMaxDec(minimumGasUsed, math.LegacyNewDec(int64(temporaryGasUsed))).TruncateInt().Uint64() | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
| @@ -430,7 +431,7 @@ | |||
| // calculate a minimum amount of gas to be charged to sender if GasLimit | |||
| // is considerably higher than GasUsed to stay more aligned with Tendermint gas mechanics | |||
| // for more info https://github.com/evmos/ethermint/issues/1085 | |||
| gasLimit := sdk.NewDec(int64(msg.Gas())) | |||
| gasLimit := math.LegacyNewDec(int64(msg.Gas())) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
| @@ -64,7 +65,7 @@ | |||
|
|
|||
| // Observe which users define a gas limit >> gas used. Note, that | |||
| // gas_limit and gas_used are always > 0 | |||
| gasLimit := sdk.NewDec(int64(tx.Gas())) | |||
| gasLimit := math.LegacyNewDec(int64(tx.Gas())) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
=======================================
Coverage 69.02% 69.02%
=======================================
Files 301 301
Lines 23638 23638
=======================================
Hits 16317 16317
Misses 6433 6433
Partials 888 888
|
GAtom22
requested review from
facs95,
MalteHerrmann,
Vvaradinov,
fedekunze and
0xstepit
and removed request for
a team
fedekunze
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #XXX