imp(staking): replace bech32 address with evm hex address for Createvalidator function

[luchenqun]

Description

I changed the input parameter string memory validatorAddress in the precompiled contract function createValidator to address validatorAddress. For this input parameter, for example:
it was evmosvaloper1hajh6rhhkjqkwet6wqld3lgx8ur4y3khljfx82 before,
but now it is 0xbf657D0ef7b48167657A703Ed8Fd063F075246D7.
see more details #2076 , Of course, I have also updated the relevant unit tests.

Further Discussion

For the two input parameters delegatorAddress and validatorAddress in the createValidator function. I think we only need to keep the validatorAddress in it, because they are essentially the same address. More detailed information can be found in the cosmos sdk related code:
https://github.com/cosmos/cosmos-sdk/blob/e049998eb5f2582fe0bb5ab102f0de87b1466534/proto/cosmos/staking/v1beta1/tx.proto#L71-L75

https://github.com/evmos/cosmos-sdk/blob/ab1087a4131e5798ef3a21cefb362800498a67de/x/staking/types/msg.go#L99-L101

Therefore, I suggest that the createValidator function in the pre-compiled contract StakingI.sol be change from

    function createValidator(
        ......
        address delegatorAddress,
        string memory validatorAddress,
        ......
    ) external returns (bool success);

to

    function createValidator(
        ......
        address validatorAddress,
        ......
    ) external returns (bool success);

and for the event CreateValidator change from

    event CreateValidator(
        address indexed delegatorAddress,
        address indexed validatorAddress,
        ......
    );

to

    event CreateValidator(
        address indexed validatorAddress,
        ......
    );

[codecov]

Codecov Report

Merging #2122 (9e8d599) into main (f179530) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 87.50%.

❗ Current head 9e8d599 differs from pull request most recent head 68e84bf. Consider uploading reports for the commit 68e84bf to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2122   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files         304      304           
  Lines       23737    23742    +5     
=======================================
+ Hits        16403    16408    +5     
  Misses       6433     6433           
  Partials      901      901           

Files	Coverage Δ
precompiles/staking/types.go	87.33% <100.00%> (-0.12%)	⬇️
precompiles/staking/tx.go	88.37% <80.00%> (-0.05%)	⬇️
precompiles/staking/events.go	72.36% <81.25%> (+1.26%)	⬆️

[Vvaradinov]

LGTM! Thank you for this @luchenqun!

[MalteHerrmann]

Looks good @luchenqun! Thanks a lot for the contribution. I do agree with adjusting the call signature to remove the delegatorAddress since it makes no sense to pass the same address twice.

[luchenqun]

Looks good @luchenqun! Thanks a lot for the contribution. I do agree with adjusting the call signature to remove the delegatorAddress since it makes no sense to pass the same address twice.

Okay, I'll implement that feature later.

[luchenqun]

@Vvaradinov @MalteHerrmann delegatorAddress has been removed and related tests have been updated. I am very happy that createValidator has finally been implemented relatively completely. Thank you for your review.

[CLAassistant]

All committers have signed the CLA.

[MalteHerrmann]

LGTM! Thanks @luchenqun 🙏