Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): remove old upgrade handlers logic #2139

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Dec 5, 2023

Description


Closes #XXX

@GAtom22 GAtom22 changed the title chore: remove old upgrade handlers logic chore(app): remove old upgrade handlers logic Dec 5, 2023
@MalteHerrmann
Copy link
Contributor

I think we need the second to last upgrade information for the upgrade tests. IIRC that logic looks for the available upgrade folders and uses the second to last one as the default initial version for the upgrade

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #2139 (233c22c) into main (f179530) will increase coverage by 0.55%.
Report is 3 commits behind head on main.
The diff coverage is 87.87%.

❗ Current head 233c22c differs from pull request most recent head 2f45129. Consider uploading reports for the commit 2f45129 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
+ Coverage   69.10%   69.65%   +0.55%     
==========================================
  Files         304      294      -10     
  Lines       23737    23126     -611     
==========================================
- Hits        16403    16108     -295     
+ Misses       6433     6151     -282     
+ Partials      901      867      -34     
Files Coverage Δ
app/app.go 80.90% <100.00%> (+1.39%) ⬆️
precompiles/staking/types.go 87.33% <100.00%> (-0.12%) ⬇️
precompiles/staking/tx.go 88.37% <80.00%> (-0.05%) ⬇️
precompiles/staking/events.go 72.36% <81.25%> (+1.26%) ⬆️

... and 1 file with indirect coverage changes

@GAtom22 GAtom22 marked this pull request as ready for review December 5, 2023 13:47
@GAtom22 GAtom22 requested a review from a team as a code owner December 5, 2023 13:47
@GAtom22 GAtom22 requested review from Vvaradinov and 0xstepit and removed request for a team December 5, 2023 13:47
@fedekunze fedekunze enabled auto-merge (squash) December 5, 2023 14:18
@fedekunze fedekunze merged commit 697f581 into main Dec 5, 2023
25 of 27 checks passed
@fedekunze fedekunze deleted the GAtom22/upgrade-handlers branch December 5, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants