imp(erc20-precompile): Adjust required gas on ERC20 extension #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
commented
Dec 6, 2023
Comment on lines
+215
to
+217
| // FIXME: Interestingly, on these tests the gas used is not in the same range, but on the specific gas consumption tests it's shown that it fits quite good | ||
| // The gas values consumed here are in line with the ones consumed by the ERC20 Solidity contracts on the first call, but on follow up calls it will be cheaper. | ||
| Entry(" - direct call", directCall, int64(30_000), int64(31_000)), |
There was a problem hiding this comment.
As can be seen in the gas tests results linked in the PR description, this is the amount for any calls except for the very first - that's why this value was chosen, even though it is lower than the values for the ERC20 Solidity calls here.
fedekunze
changed the base branch from
main
to
Vvaradinov/feat-strv2-feature-branch
MalteHerrmann
requested review from
Vvaradinov and
0xstepit
and removed request for
a team
ramacarlucho
approved these changes
Feb 8, 2024
ramacarlucho
reviewed
Feb 8, 2024
MalteHerrmann
merged commit eff5480
into
Vvaradinov/feat-strv2-feature-branch
25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the required gas values on the transactions that have been successfully tested so far. These gas values have been used in the gas tests to match the Solidity contract consumption (Results).
Closes ENG-2369