imp(cli): remove ValidateBasic in cli #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukema95
requested review from
Vvaradinov and
MalteHerrmann
and removed request for
a team
|
|
lukema95
changed the title
MalteHerrmann
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
LGTM, thanks for the contribution 👍
Can confirm that the respective code is included in our fork, too:
https://github.com/evmos/cosmos-sdk/blob/7a885823bc4a8a72c41dcd1381cba9819f487349/client/tx/tx.go#L35-L43
fedekunze
previously requested changes
Jan 3, 2024
…ema95/evmos into remove-redundant-ValidateBasic-check
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ValidateBasicfunction has been called in theGenerateOrBroadcastTxWithFactoryfunction, so we no longer need to add theValidateBasicfunction when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)Closes #XXX