fix(str): Revert deleted RegisterCoinProposal protos and types #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
requested review from
hanchon and
GAtom22
and removed request for
a team
…evert-register-coin-proposal
…evert-register-coin-proposal
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## Vvaradinov/feat-strv2-feature-branch #2276 +/- ##
========================================================================
- Coverage 70.72% 70.63% -0.10%
========================================================================
Files 293 293
Lines 22551 22587 +36
========================================================================
+ Hits 15950 15955 +5
- Misses 5734 5765 +31
Partials 867 867
|
facs95
approved these changes
Jan 17, 2024
ramacarlucho
approved these changes
Jan 17, 2024
Vvaradinov
merged commit bd10bcd
into
Vvaradinov/feat-strv2-feature-branch
27 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per discussion with the team we are reverting the deletion of
RegisterCoinProposalin order to not break existing proposals on chain as well as for archival nodes. This alternative only removes theRegisterCoinProposalfrom the proposal handler effectively rendering it unreachable.Closes #XXX