-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(erc20): revert unnecessary logic on genesis #2292
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
- Coverage 70.48% 70.43% -0.05%
==========================================
Files 294 293 -1
Lines 22640 22539 -101
==========================================
- Hits 15957 15875 -82
+ Misses 5814 5801 -13
+ Partials 869 863 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR removes unnecessary logic from the genesis of the erc20 module.
This logic should not include the deployment of the corresponding erc20 contracts for the token pairs, but these should be included on the genesis of the evm module.
For reference on how this would look like, check the
osmosis-outpost.jsonnet
fileCloses #XXX