Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(erc20): revert unnecessary logic on genesis #2292

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Jan 24, 2024

Description

This PR removes unnecessary logic from the genesis of the erc20 module.

This logic should not include the deployment of the corresponding erc20 contracts for the token pairs, but these should be included on the genesis of the evm module.

For reference on how this would look like, check the osmosis-outpost.jsonnet file


Closes #XXX

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51cc816) 70.48% compared to head (ae13493) 70.43%.
Report is 1 commits behind head on main.

❗ Current head ae13493 differs from pull request most recent head 46bb04a. Consider uploading reports for the commit 46bb04a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
- Coverage   70.48%   70.43%   -0.05%     
==========================================
  Files         294      293       -1     
  Lines       22640    22539     -101     
==========================================
- Hits        15957    15875      -82     
+ Misses       5814     5801      -13     
+ Partials      869      863       -6     
Files Coverage Δ
x/erc20/genesis.go 72.22% <100.00%> (+22.22%) ⬆️
x/erc20/keeper/evm.go 88.23% <93.75%> (+3.05%) ⬆️

@GAtom22 GAtom22 marked this pull request as ready for review January 24, 2024 18:38
@GAtom22 GAtom22 requested a review from a team as a code owner January 24, 2024 18:38
@GAtom22 GAtom22 requested review from facs95 and MalteHerrmann and removed request for a team January 24, 2024 18:38
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GAtom22 GAtom22 enabled auto-merge (squash) January 25, 2024 13:34
@fedekunze fedekunze enabled auto-merge (squash) January 25, 2024 14:01
@fedekunze fedekunze merged commit 92c35a2 into main Jan 25, 2024
35 of 36 checks passed
@fedekunze fedekunze deleted the GAtom22/revert-gen branch January 25, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants