Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gas.md - grammar fixes #23

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Update gas.md - grammar fixes #23

merged 1 commit into from
Oct 4, 2021

Conversation

git-sgmoore
Copy link
Contributor

@git-sgmoore git-sgmoore commented Oct 3, 2021 •
edited

Two grammar fixes at lines 17 and 18.

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@git-sgmoore
Update gas.md - grammar fixes
bd26bde 
Two grammar fixes at lines 17 and 18.
fedekunze
fedekunze approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fedekunze fedekunze merged commit aac1f81 into evmos:main Oct 4, 2021
@git-sgmoore git-sgmoore deleted the patch-5 branch October 4, 2021 13:12
faddat referenced this pull request in notional-labs/evmos Dec 9, 2021
@fedekunze
proto, evm: use string for address and hash protobuf message fields (#23
ba5bf33 
)

* proto, evm: use string for address and hash protobuf message fields

* fix tests

* msg test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@git-sgmoore @fedekunze