Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix mergify #231

Merged
merged 2 commits into from
Jan 25, 2022
Merged

build: fix mergify #231

merged 2 commits into from
Jan 25, 2022

Conversation

prajjwol
Copy link
Contributor

Closes: #ENG-444

Description

https://blog.mergify.com/strict-mode-deprecation/


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@linear
Copy link

linear bot commented Jan 22, 2022

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says that the configuration is still invalid

@prajjwol
Copy link
Contributor Author

prajjwol commented Jan 25, 2022

@fedekunze I think it needs to make it to the master, it's complaining about extra keys not allowed @ pull_request_rules → item 0 → actions → merge → strict which I removed in this PR

@fedekunze fedekunze merged commit 3822b39 into main Jan 25, 2022
@fedekunze fedekunze deleted the prajjwol/eng-444-fix_mergify branch January 25, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants