Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str(tests): Add nix e2e tests #2313

Merged

Conversation

Vvaradinov
Copy link
Contributor

Description

This PR adds nix e2e tests, the binaries will change to linux ones for the cosmos hub once this PR is ready.


Closes XAP-54

Copy link

linear bot commented Feb 1, 2024

Copy link

coderabbitai bot commented Feb 1, 2024

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the tests label Feb 1, 2024
tests/nix_tests/test_str_v2.py Fixed Show fixed Hide fixed
tests/nix_tests/test_str_v2.py Fixed Show fixed Hide fixed
tests/nix_tests/test_str_v2.py Fixed Show fixed Hide fixed
tests/nix_tests/test_str_v2.py Fixed Show fixed Hide fixed
tests/nix_tests/test_str_v2.py Fixed Show fixed Hide fixed
…tr-nix-tests

# Conflicts:
#	app/upgrades/v16/upgrades.go
#	precompiles/werc20/integration_test.go
#	proto/ethermint/evm/v1/evm.proto
#	tests/nix_tests/configs/str-v2.jsonnet
#	x/erc20/keeper/precompiles.go
#	x/erc20/keeper/precompiles_test.go
#	x/evm/keeper/dynamic_precompiles.go
#	x/evm/keeper/params.go
#	x/evm/keeper/precompiles.go
#	x/evm/keeper/state_transition.go
#	x/evm/keeper/static_precompiles.go
#	x/evm/keeper/static_precompiles_test.go
#	x/evm/types/evm.pb.go
#	x/evm/types/params.go
@Vvaradinov Vvaradinov marked this pull request as ready for review February 21, 2024 09:40
@Vvaradinov Vvaradinov requested a review from a team as a code owner February 21, 2024 09:40
@Vvaradinov Vvaradinov requested review from hanchon and GAtom22 and removed request for a team February 21, 2024 09:40
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Vvaradinov!!
Left a few questions

Also there're some lint issues

tests/nix_tests/configs/default.jsonnet Outdated Show resolved Hide resolved
tests/nix_tests/test_str_v2.py Outdated Show resolved Hide resolved
tests/nix_tests/test_str_v2.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ramacarlucho ramacarlucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also test a evmos transfer

tests/nix_tests/configs/default.jsonnet Show resolved Hide resolved
tests/nix_tests/configs/default.jsonnet Outdated Show resolved Hide resolved
tests/nix_tests/utils.py Outdated Show resolved Hide resolved
tests/nix_tests/test_str_v2.py Outdated Show resolved Hide resolved
@Vvaradinov Vvaradinov merged commit 2545bf5 into Vvaradinov/feat-strv2-feature-branch Feb 21, 2024
32 checks passed
@Vvaradinov Vvaradinov deleted the Vvaradinov/str-nix-tests branch February 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants