Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v16.0.4 #2460

Merged
merged 5 commits into from Apr 5, 2024
Merged

Prepare for v16.0.4 #2460

merged 5 commits into from Apr 5, 2024

Conversation

ramacarlucho
Copy link
Collaborator

Description

Schedule upgrade on block #20_101_000

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@ramacarlucho ramacarlucho requested a review from a team as a code owner April 5, 2024 15:28
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 69.31%. Comparing base (fcedcf5) to head (b1c00e5).
Report is 8 commits behind head on release/v16.0.x.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v16.0.x    #2460      +/-   ##
===================================================
+ Coverage            69.29%   69.31%   +0.02%     
===================================================
  Files                  296      296              
  Lines                23465    23480      +15     
===================================================
+ Hits                 16260    16276      +16     
+ Misses                6320     6318       -2     
- Partials               885      886       +1     
Files Coverage Δ
app/app.go 79.37% <0.00%> (+0.09%) ⬆️
app/forks.go 0.00% <0.00%> (ø)

app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/v17/upgrades.go Outdated Show resolved Hide resolved
app/forks.go Outdated Show resolved Hide resolved
@0xstepit 0xstepit self-requested a review April 5, 2024 15:51
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for preparing @ramacarlucho

ramacarlucho and others added 3 commits April 5, 2024 13:36
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
@facs95 facs95 merged commit 9c9086b into release/v16.0.x Apr 5, 2024
38 of 44 checks passed
@facs95 facs95 deleted the rama/prepare-v16.0.4 branch April 5, 2024 17:00
ramacarlucho added a commit that referenced this pull request Apr 5, 2024
* Prepare for v16.0.4 (#2460)

* initial upgrade logic

* gofumpt

* Apply suggestions from code review

Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>

* run make format

* delete unused logger

---------

Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
Co-authored-by: ramacarlucho <ramacarlucho@users.noreply.github.com>

* chore(docker): update docker deps (#2463)

* update docker deps

* ignore link in failing ci

* use fixed golangci-lint version for v17

---------

Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
Co-authored-by: ramacarlucho <ramacarlucho@users.noreply.github.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants