Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.0.0 upgrade logic #2491

Merged
merged 8 commits into from Apr 18, 2024
Merged

v18.0.0 upgrade logic #2491

merged 8 commits into from Apr 18, 2024

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Apr 18, 2024

Description


Upgrade handler for v18.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@facs95 facs95 requested a review from a team as a code owner April 18, 2024 15:02
@facs95 facs95 requested review from hanchon and 0xstepit April 18, 2024 15:02
@GAtom22
Copy link
Contributor

GAtom22 commented Apr 18, 2024

Please, address the lint issue

@GAtom22
Copy link
Contributor

GAtom22 commented Apr 18, 2024

also you'll need to add these changes to fix the codecov report (reason why unit tests action is failing)

@facs95 facs95 enabled auto-merge (squash) April 18, 2024 19:13
@facs95 facs95 merged commit 7fe1ba8 into release/v17.0.x Apr 18, 2024
35 of 38 checks passed
@facs95 facs95 deleted the facs95/v17.0.1 branch April 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants