Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibctesting: cleanup and refactor #282

Merged
merged 6 commits into from
Mar 4, 2022
Merged

ibctesting: cleanup and refactor #282

merged 6 commits into from
Mar 4, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Feb 19, 2022

  • Bump ibc-go to v3-rc1
  • Remove dup code

@fedekunze fedekunze changed the title ibctest: cleanup and refactor ibctesting: cleanup and refactor Mar 4, 2022
@fedekunze fedekunze marked this pull request as ready for review March 4, 2022 17:49
@fedekunze fedekunze enabled auto-merge (squash) March 4, 2022 17:51
@fedekunze fedekunze disabled auto-merge March 4, 2022 17:51
@fedekunze fedekunze enabled auto-merge (squash) March 4, 2022 17:51
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #282 (2dcc097) into main (35ecc64) will increase coverage by 11.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #282       +/-   ##
===========================================
+ Coverage   65.51%   77.20%   +11.69%     
===========================================
  Files          94       89        -5     
  Lines        6159     5212      -947     
===========================================
- Hits         4035     4024       -11     
+ Misses       1973     1037      -936     
  Partials      151      151               
Impacted Files Coverage Δ
ibctesting/chain.go
ibctesting/coordinator.go
ibctesting/app.go

Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice that they have it on the sdk

@fedekunze fedekunze merged commit 1bd0bf6 into main Mar 4, 2022
@fedekunze fedekunze deleted the remove-ibc-go-testing branch March 4, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants