-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: upgrade v1.1.2 to v2 #354
app: upgrade v1.1.2 to v2 #354
Conversation
use newer sdk version instructions run migrations and set modules versions to 1 add TODO use osmosis style upgrade handlers remove upgrade handler for olympus mons make note of inflation module change as well add store loaders upgrade set the params for erc20 module set the params for claims pass in keeers to upgrade handler apply upgrade at specified height remove store loaders upgrade bump the claims consensus version add binaries info to upgrade info add new claims params add comment throw upgrade plan at cosmovisor clean up changes that should be in v2 clean up changes that should be in v2, again remove extra dependency
c537691
to
ba858dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, pending changelog entry and go mod tidy
Codecov Report
@@ Coverage Diff @@
## release/v1.1.x #354 +/- ##
==================================================
- Coverage 65.58% 65.47% -0.11%
==================================================
Files 93 95 +2
Lines 6145 6172 +27
==================================================
+ Hits 4030 4041 +11
- Misses 1963 1980 +17
+ Partials 152 151 -1
|
* release: v1.1.0 (#324) * release: v1.1.1 (#346) * fix conflicts * conflicts Co-authored-by: Prajjwol Gautam <not@acyb.org> * app: upgrade v1.1.2 logic to v2 (#354) * app: set up upgrade handler for v2 use newer sdk version instructions run migrations and set modules versions to 1 add TODO use osmosis style upgrade handlers remove upgrade handler for olympus mons make note of inflation module change as well add store loaders upgrade set the params for erc20 module set the params for claims pass in keeers to upgrade handler apply upgrade at specified height remove store loaders upgrade bump the claims consensus version add binaries info to upgrade info add new claims params add comment throw upgrade plan at cosmovisor clean up changes that should be in v2 clean up changes that should be in v2, again remove extra dependency * go mod tidy * add changelog * Update fork code to use something closer to upgrade module * Fix improt error * remove upgrade height check * log errors * panic on error instead * add back height gate * add missing bracket * erc20 migrator * nolint * claims migration * add TODO * rm erc20 upgrade * don't register migration for claims * update changelog Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * update fork.go Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com> Co-authored-by: ValarDragon <dojha12@gmail.com>
* app: set up upgrade handler for v2 * use newer sdk version instructions * run migrations and set modules versions to 1 * add TODO * use osmosis style upgrade handlers * remove upgrade handler for olympus mons * make note of inflation module change as well * add store loaders upgrade * set the params for erc20 module * set the params for claims * pass in keeers to upgrade handler * apply upgrade at specified height * remove store loaders upgrade * bump the claims consensus version * add binaries info to upgrade info * add new claims params * add comment * insert sdk fork and upgrade handler * update dependencies to v2 * remove old fork * docs: use `go install` for cosmovisor (#356) * docs: add `v1.0.0` to cosmovisor install (#357) * remove old evmos * go mod tidy * fix upgrade handler to not replace version map * docs: cosmovisor v2 upgrade preparation docs (#358) * docs: fix rpc urls * docs: v2 upgrade instructions for cosmovisor * add details for latest v1 release * release: `v1.1.2` changelog (#359) * release: v1.1.0 (#324) * release: v1.1.1 (#346) * fix conflicts * conflicts Co-authored-by: Prajjwol Gautam <not@acyb.org> * app: upgrade v1.1.2 logic to v2 (#354) * app: set up upgrade handler for v2 use newer sdk version instructions run migrations and set modules versions to 1 add TODO use osmosis style upgrade handlers remove upgrade handler for olympus mons make note of inflation module change as well add store loaders upgrade set the params for erc20 module set the params for claims pass in keeers to upgrade handler apply upgrade at specified height remove store loaders upgrade bump the claims consensus version add binaries info to upgrade info add new claims params add comment throw upgrade plan at cosmovisor clean up changes that should be in v2 clean up changes that should be in v2, again remove extra dependency * go mod tidy * add changelog * Update fork code to use something closer to upgrade module * Fix improt error * remove upgrade height check * log errors * panic on error instead * add back height gate * add missing bracket * erc20 migrator * nolint * claims migration * add TODO * rm erc20 upgrade * don't register migration for claims * update changelog Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * update fork.go Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com> Co-authored-by: ValarDragon <dojha12@gmail.com> * upgrade handler * cleanup * register erc20 migration * deps: bump ethermint to v0.11.0 (#360) * deps: bump ethermint to v0.11.0 * changelog * bump ethermint Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
* release: bump Evmos version to v2 (#351) * fix changelog * fix * swagger * swagger * fix * go mod * app: upgrade handler for v2 (#352) * app: set up upgrade handler for v2 * use newer sdk version instructions * run migrations and set modules versions to 1 * add TODO * use osmosis style upgrade handlers * remove upgrade handler for olympus mons * make note of inflation module change as well * add store loaders upgrade * set the params for erc20 module * set the params for claims * pass in keeers to upgrade handler * apply upgrade at specified height * remove store loaders upgrade * bump the claims consensus version * add binaries info to upgrade info * add new claims params * add comment * insert sdk fork and upgrade handler * update dependencies to v2 * remove old fork * docs: use `go install` for cosmovisor (#356) * docs: add `v1.0.0` to cosmovisor install (#357) * remove old evmos * go mod tidy * fix upgrade handler to not replace version map * docs: cosmovisor v2 upgrade preparation docs (#358) * docs: fix rpc urls * docs: v2 upgrade instructions for cosmovisor * add details for latest v1 release * release: `v1.1.2` changelog (#359) * release: v1.1.0 (#324) * release: v1.1.1 (#346) * fix conflicts * conflicts Co-authored-by: Prajjwol Gautam <not@acyb.org> * app: upgrade v1.1.2 logic to v2 (#354) * app: set up upgrade handler for v2 use newer sdk version instructions run migrations and set modules versions to 1 add TODO use osmosis style upgrade handlers remove upgrade handler for olympus mons make note of inflation module change as well add store loaders upgrade set the params for erc20 module set the params for claims pass in keeers to upgrade handler apply upgrade at specified height remove store loaders upgrade bump the claims consensus version add binaries info to upgrade info add new claims params add comment throw upgrade plan at cosmovisor clean up changes that should be in v2 clean up changes that should be in v2, again remove extra dependency * go mod tidy * add changelog * Update fork code to use something closer to upgrade module * Fix improt error * remove upgrade height check * log errors * panic on error instead * add back height gate * add missing bracket * erc20 migrator * nolint * claims migration * add TODO * rm erc20 upgrade * don't register migration for claims * update changelog Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * update fork.go Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com> Co-authored-by: ValarDragon <dojha12@gmail.com> * upgrade handler * cleanup * register erc20 migration * deps: bump ethermint to v0.11.0 (#360) * deps: bump ethermint to v0.11.0 * changelog * bump ethermint Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * Merge pull request from GHSA-5jgq-x857-p8xw * fix: only enable claims from authorized channels * changelog * changelog 2 * fix tests * rename to authorized * update forks * upgrade height * check for EVM chains * bonded ration adjustment * update genesis * fixes * swagger Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: ValarDragon <dojha12@gmail.com>
* release: bump Evmos version to v2 (#351) * fix changelog * fix * swagger * swagger * fix * go mod * app: upgrade handler for v2 (#352) * app: set up upgrade handler for v2 * use newer sdk version instructions * run migrations and set modules versions to 1 * add TODO * use osmosis style upgrade handlers * remove upgrade handler for olympus mons * make note of inflation module change as well * add store loaders upgrade * set the params for erc20 module * set the params for claims * pass in keeers to upgrade handler * apply upgrade at specified height * remove store loaders upgrade * bump the claims consensus version * add binaries info to upgrade info * add new claims params * add comment * insert sdk fork and upgrade handler * update dependencies to v2 * remove old fork * docs: use `go install` for cosmovisor (#356) * docs: add `v1.0.0` to cosmovisor install (#357) * remove old evmos * go mod tidy * fix upgrade handler to not replace version map * docs: cosmovisor v2 upgrade preparation docs (#358) * docs: fix rpc urls * docs: v2 upgrade instructions for cosmovisor * add details for latest v1 release * release: `v1.1.2` changelog (#359) * release: v1.1.0 (#324) * release: v1.1.1 (#346) * fix conflicts * conflicts Co-authored-by: Prajjwol Gautam <not@acyb.org> * app: upgrade v1.1.2 logic to v2 (#354) * app: set up upgrade handler for v2 use newer sdk version instructions run migrations and set modules versions to 1 add TODO use osmosis style upgrade handlers remove upgrade handler for olympus mons make note of inflation module change as well add store loaders upgrade set the params for erc20 module set the params for claims pass in keeers to upgrade handler apply upgrade at specified height remove store loaders upgrade bump the claims consensus version add binaries info to upgrade info add new claims params add comment throw upgrade plan at cosmovisor clean up changes that should be in v2 clean up changes that should be in v2, again remove extra dependency * go mod tidy * add changelog * Update fork code to use something closer to upgrade module * Fix improt error * remove upgrade height check * log errors * panic on error instead * add back height gate * add missing bracket * erc20 migrator * nolint * claims migration * add TODO * rm erc20 upgrade * don't register migration for claims * update changelog Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * update fork.go Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com> Co-authored-by: ValarDragon <dojha12@gmail.com> * upgrade handler * cleanup * register erc20 migration * deps: bump ethermint to v0.11.0 (#360) * deps: bump ethermint to v0.11.0 * changelog * bump ethermint Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * Merge pull request from GHSA-5jgq-x857-p8xw * fix: only enable claims from authorized channels * changelog * changelog 2 * fix tests * rename to authorized * update forks * upgrade height * check for EVM chains * bonded ration adjustment * update genesis * fixes * swagger * fix: don't use GetParams (#363) Co-authored-by: Akash Khosla <8366960+khoslaventures@users.noreply.github.com> Co-authored-by: Prajjwol Gautam <not@acyb.org> Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
// Migrate1to2 migrates from consensus version 1 to 2. | ||
func (m Migrator) Migrate1to2(ctx sdk.Context) error { | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seams that this is not needed, there is no state machine change / migration in the erc20 module.
Description
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...