Fixing subtle bug in genesis verification post-export #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
approved these changes
Mar 9, 2022
| for _, actionCompleted := range cr.ActionsCompleted { | ||
| if !actionCompleted { | ||
| // NOTE: only add the initial claimable amount per action for the ones that haven't been claimed | ||
| sumUnclaimed = sumUnclaimed.Add(initialClaimablePerAction) |
There was a problem hiding this comment.
You have to use:
https://github.com/tharsis/evmos/blob/f5dfed87da17ee61c1338f8d70b27f26f3d1b17a/x/claims/keeper/claim.go#L11
If you don't, genesis export will fail on decay of the claims balances. It was in the previous commit for a reason.
There was a problem hiding this comment.
Agreed... if we can incorporate this now.. it will prevent us from having to remember that detail should we ever need to export state again in the next few months
There was a problem hiding this comment.
@fedekunze ^^ I'll make an updated PR to this effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While attempting to export the state to genesis and create a testnet, it was discovered that the InitGenesis.go hadn't considered and export after claims were completed.
Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...