Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: claims invariants #385

Merged
merged 17 commits into from
Mar 21, 2022
Merged

imp: claims invariants #385

merged 17 commits into from
Mar 21, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Mar 11, 2022

Description

Closes: #XXX


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@fedekunze fedekunze marked this pull request as ready for review March 11, 2022 08:47
@fedekunze fedekunze marked this pull request as draft March 11, 2022 08:47
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #385 (935c0ff) into main (daf5b06) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 935c0ff differs from pull request most recent head c57b9b6. Consider uploading reports for the commit c57b9b6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   78.17%   78.40%   +0.22%     
==========================================
  Files          93       94       +1     
  Lines        5456     5514      +58     
==========================================
+ Hits         4265     4323      +58     
  Misses       1035     1035              
  Partials      156      156              
Impacted Files Coverage Δ
x/claims/keeper/claim.go 100.00% <100.00%> (ø)
x/claims/keeper/grpc_query.go 84.41% <100.00%> (+0.41%) ⬆️
x/claims/keeper/invariants.go 100.00% <100.00%> (ø)

@fedekunze fedekunze marked this pull request as ready for review March 18, 2022 17:12
@fedekunze fedekunze marked this pull request as draft March 18, 2022 17:15
@fedekunze fedekunze marked this pull request as ready for review March 18, 2022 17:55
x/claims/keeper/claim.go Show resolved Hide resolved
x/claims/keeper/claim.go Outdated Show resolved Hide resolved
x/claims/keeper/invariants_test.go Show resolved Hide resolved
@fedekunze fedekunze requested a review from jolube March 21, 2022 08:31
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, left minor comments

x/claims/keeper/invariants.go Outdated Show resolved Hide resolved
x/claims/keeper/invariants.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) March 21, 2022 09:38
@fedekunze fedekunze merged commit bb46a34 into main Mar 21, 2022
@fedekunze fedekunze deleted the fedekunze/claims-invariants branch March 21, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants