Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to v3 #415

Merged
merged 3 commits into from
Mar 22, 2022
Merged

bump version to v3 #415

merged 3 commits into from
Mar 22, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Mar 22, 2022

Description

Ref: ENG-64

Bump evmos version to v3 for upcoming release


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@fedekunze fedekunze marked this pull request as ready for review March 22, 2022 12:32
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the breaking change?

@fedekunze
Copy link
Contributor Author

What's the breaking change?

API breaking since projects and other libraries using evmos will have to change to v3 too

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #415 (9aff9b3) into main (43350df) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 9aff9b3 differs from pull request most recent head d2172fb. Consider uploading reports for the commit d2172fb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   79.12%   79.20%   +0.07%     
==========================================
  Files          99       99              
  Lines        5577     5597      +20     
==========================================
+ Hits         4413     4433      +20     
  Misses       1012     1012              
  Partials      152      152              
Impacted Files Coverage Δ
app/app.go 84.62% <ø> (ø)
app/forks.go 0.00% <ø> (ø)
ibc/utils.go 100.00% <ø> (ø)
x/claims/genesis.go 76.08% <ø> (ø)
x/claims/handler.go 20.00% <ø> (ø)
x/claims/ibc_module.go 27.77% <ø> (ø)
x/claims/keeper/abci.go 79.09% <ø> (ø)
x/claims/keeper/claim.go 100.00% <ø> (ø)
x/claims/keeper/claims_records.go 96.07% <ø> (ø)
x/claims/keeper/grpc_query.go 84.41% <ø> (ø)
... and 54 more

@fedekunze fedekunze enabled auto-merge (squash) March 22, 2022 13:49
@fedekunze fedekunze merged commit c648008 into main Mar 22, 2022
@fedekunze fedekunze deleted the fedekunze/bump-v3 branch March 22, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants