Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBC trigger amount to claims merge/migrate IBC callbacks #432

Merged
merged 10 commits into from
Mar 25, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Mar 25, 2022

Description

This PR adds an additional encumbrance (packet amount IBCTriggerAmt) for users to merge/migrate their non-Evmos claims records.

@linear
Copy link

linear bot commented Mar 25, 2022

ENG-100 Users might accidentally transfer their claims to an address they don’t own

Claims records on Osmosis/Cosmos can be merged or migrated to an Evmos address by performing an IBC transfer. To prevent this from happening by accident, an additional step can be added for user who want to merge or migrate their claims.

=> only merge/migrate, when IBC tx has specified amount (e.g. 0.0003940000000). This reduces the surface area of possible harm to the majority of users.

@danburck danburck changed the title ENG 100 merge migrate with ibc amount Add IBC trigger amount to claims merge/migrate IBC callbacks Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #432 (af13c3e) into main (e776e09) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   78.76%   78.78%   +0.02%     
==========================================
  Files         105      105              
  Lines        5876     5896      +20     
==========================================
+ Hits         4628     4645      +17     
- Misses       1086     1088       +2     
- Partials      162      163       +1     
Impacted Files Coverage Δ
x/claims/types/claims_record.go 100.00% <ø> (ø)
x/claims/keeper/ibc_callbacks.go 97.67% <72.72%> (-2.33%) ⬇️
ibc/utils.go 100.00% <100.00%> (ø)

@danburck danburck marked this pull request as ready for review March 25, 2022 09:59
ibc/utils.go Outdated Show resolved Hide resolved
ibc/utils.go Outdated Show resolved Hide resolved
ibc/utils_test.go Show resolved Hide resolved
@fedekunze fedekunze merged commit 88b6bf0 into main Mar 25, 2022
@fedekunze fedekunze deleted the ENG-100-merge-migrate-with-ibc-amount branch March 25, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants