Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit(incentives): only distribute incentives to EOAs #551

Merged
merged 9 commits into from
May 5, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented May 4, 2022

Description

Closes: #XXX

This PR adds a safety check to only distribute incentives to EOAs (which should still be the case given that the EVM Hook in ApplyTransaction can only be called through a user-generated transaction to the EVM)


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #551 (8caacf1) into main (57dd8a2) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

❗ Current head 8caacf1 differs from pull request most recent head 6fd1e69. Consider uploading reports for the commit 6fd1e69 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   83.35%   83.26%   -0.10%     
==========================================
  Files         114      115       +1     
  Lines        6322     6340      +18     
==========================================
+ Hits         5270     5279       +9     
- Misses        926      933       +7     
- Partials      126      128       +2     
Impacted Files Coverage Δ
x/incentives/keeper/evm_hooks.go 83.78% <62.50%> (-5.88%) ⬇️
x/incentives/keeper/proposals.go 100.00% <100.00%> (ø)
x/erc20/keeper/migrations.go 66.66% <0.00%> (-33.34%) ⬇️
x/erc20/migrations/v2/migration.go 50.00% <0.00%> (ø)

@fedekunze fedekunze marked this pull request as ready for review May 4, 2022 19:40
@fedekunze fedekunze requested a review from danburck as a code owner May 4, 2022 19:40
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Copy link
Contributor

@Prosp3r Prosp3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@fedekunze fedekunze enabled auto-merge (squash) May 5, 2022 13:43
@fedekunze fedekunze merged commit e9df125 into main May 5, 2022
@fedekunze fedekunze deleted the fedekunze/incentives-eoa branch May 5, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants