-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit(incentives): only distribute incentives to EOAs #551
Conversation
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
- Coverage 83.35% 83.26% -0.10%
==========================================
Files 114 115 +1
Lines 6322 6340 +18
==========================================
+ Hits 5270 5279 +9
- Misses 926 933 +7
- Partials 126 128 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good
Description
Closes: #XXX
This PR adds a safety check to only distribute incentives to EOAs (which should still be the case given that the EVM Hook in
ApplyTransaction
can only be called through a user-generated transaction to the EVM)All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...