Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v4 upgrade logic #555

Merged
merged 17 commits into from
May 9, 2022
Merged

release: v4 upgrade logic #555

merged 17 commits into from
May 9, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented May 4, 2022

Description

  • Add upgrade logic for the v4 upgrade
  • Refactor and improve code comments

TODOs:

  • Define upgrade height

Closes: ENG-238


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #555 (2a99f4a) into main (c76c589) will decrease coverage by 0.06%.
The diff coverage is 45.33%.

❗ Current head 2a99f4a differs from pull request most recent head b3c325a. Consider uploading reports for the commit b3c325a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   83.47%   83.41%   -0.07%     
==========================================
  Files         114      115       +1     
  Lines        6330     6361      +31     
==========================================
+ Hits         5284     5306      +22     
- Misses        920      928       +8     
- Partials      126      127       +1     
Impacted Files Coverage Δ
app/forks.go 0.00% <0.00%> (ø)
types/utils.go 80.00% <0.00%> (-10.33%) ⬇️
app/upgrades/v4/upgrades.go 69.69% <69.69%> (ø)
app/app.go 84.69% <75.00%> (+0.02%) ⬆️
x/inflation/keeper/inflation.go 82.22% <100.00%> (-0.39%) ⬇️

Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

app/upgrades/mainnet/v4/upgrades.go Outdated Show resolved Hide resolved
app/upgrades/testnet/v4/upgrades.go Outdated Show resolved Hide resolved
app/forks.go Outdated Show resolved Hide resolved
@fedekunze fedekunze marked this pull request as ready for review May 6, 2022 18:33
@fedekunze fedekunze requested a review from jolube as a code owner May 6, 2022 18:33
@github-actions github-actions bot added the types label May 9, 2022
types/utils.go Outdated Show resolved Hide resolved
app/forks.go Show resolved Hide resolved
@linear
Copy link

linear bot commented May 9, 2022

ENG-238 Create v4 upgrade handler

  • Set upgrade handler logic for v4 testnet and mainnet
    • Set Osmosis' new IBC client ID: 07-tendermint-29
    • Set Cosmos Hub' new IBC client ID: 07-tendermint-29
  • Define no-op for store upgrade
  • Add unit tests
  • Schedule upgrade on BeginBlock

fedekunze and others added 2 commits May 9, 2022 12:58
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
@fedekunze fedekunze enabled auto-merge (squash) May 9, 2022 11:02
@fedekunze fedekunze merged commit f5a66b0 into main May 9, 2022
@fedekunze fedekunze deleted the fedekunze/v4-upgrade-logic branch May 9, 2022 11:04
@fedekunze fedekunze mentioned this pull request May 9, 2022
12 tasks
loredanacirstea added a commit that referenced this pull request May 11, 2022
* main: (24 commits)
  docs: update hardhat guide (#594)
  audit(erc20): completeness (#592)
  fix: readd erc20 migration logic (#588)
  release: v3.0.1 changelog (#584)
  release: set v4 upgrade heights (#581)
  docs: fix more problems with markdown link check (#575)
  bump(ethermint): v0.15.0 (#580)
  ci: update mergify config (#579)
  release: v4 upgrade logic (#555)
  docs: upgrade deps (#578)
  docs: upgrade documentation (#572)
  Correct testnet endpoint URLs (#577)
  build(deps): bump docker/setup-qemu-action from 1 to 2 (#566)
  build(deps): bump docker/setup-buildx-action from 1 to 2 (#567)
  ci(fuzz): add fuzz function for x/incentives/types.SplitGasMeterKey (#573)
  tests(erc20): add integration tests (#571)
  build(deps): bump docker/login-action from 1 to 2 (#565)
  tests(erc20): refactor keeper tests (#561)
  Use universal cosmos gitpod image as an editing environment (#564)
  build(deps): bump docker/build-push-action from 2 to 3 (#568)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants