Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dup set claims record + CLI update #605

Merged
merged 4 commits into from
May 13, 2022

Conversation

fedekunze
Copy link
Contributor

Description

Closes: #XXX


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@github-actions github-actions bot added the docs label May 12, 2022
@fedekunze fedekunze marked this pull request as ready for review May 12, 2022 22:19
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #605 (1ab88e8) into main (1cea5a9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   85.67%   85.66%   -0.01%     
==========================================
  Files         117      117              
  Lines        6372     6371       -1     
==========================================
- Hits         5459     5458       -1     
  Misses        784      784              
  Partials      129      129              
Impacted Files Coverage Δ
x/claims/keeper/ibc_callbacks.go 97.76% <100.00%> (-0.02%) ⬇️

@github-actions github-actions bot added the CLI label May 12, 2022
@fedekunze fedekunze changed the title fix: remove dup set claims record fix: remove dup set claims record + CLI update May 12, 2022
@fedekunze fedekunze enabled auto-merge (squash) May 12, 2022 22:24
Copy link
Contributor

@Prosp3r Prosp3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viewed.
All good

@fedekunze fedekunze merged commit 3242a6e into main May 13, 2022
@fedekunze fedekunze deleted the fedekunze/claims-rm-set branch May 13, 2022 00:48
loredanacirstea added a commit that referenced this pull request May 14, 2022
* main:
  Correct inflation.proto typo (#608)
  change algolia search key (#607)
  Changing erroneous epoch skips to daily instead of weekly (#554)
  fix: remove dup set claims record + CLI update (#605)
  build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (#604)
  imp: fees test coverage (#586)
  fees: limit address derivation to 20 iterations at registration (#603)
loredanacirstea added a commit to loredanacirstea/evmos that referenced this pull request May 16, 2022
* main:
  Correct inflation.proto typo (evmos#608)
  change algolia search key (evmos#607)
  Changing erroneous epoch skips to daily instead of weekly (evmos#554)
  fix: remove dup set claims record + CLI update (evmos#605)
  build(deps): bump github.com/spf13/cast from 1.4.1 to 1.5.0 (evmos#604)
  imp: fees test coverage (evmos#586)
  fees: limit address derivation to 20 iterations at registration (evmos#603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants