deps: bump ethermint to v0.16.1 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
ramacarlucho,
khoslaventures,
jolube and
danburck
as code owners
Codecov Report
@@ Coverage Diff @@
## main #663 +/- ##
==========================================
- Coverage 82.45% 82.43% -0.03%
==========================================
Files 121 121
Lines 6805 6813 +8
==========================================
+ Hits 5611 5616 +5
- Misses 1061 1063 +2
- Partials 133 134 +1
|
ENG-439 Contracts should not create incentives gas meters
We removed the code that checks if an account that interacts with an incentivized contract is a EOA or a contract here, because it recognized EOAs as contracts. To test, I signed transactions from my EOA account using remix to interact with an incentivized contract. I noticed that the Screenshot 2022-06-08 at 09.45.32.png A fix for this should include (integration) tests that cover both cases interaction with the contract
|
danburck
approved these changes
Jun 9, 2022
danburck
pushed a commit
that referenced
this pull request
Jun 10, 2022
* deps: bump ethermint to v0.16.1 * changelog * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: ENG-439 https://linear.app/evmos/issue/ENG-439/contracts-should-not-create-incentives-gas-meters