Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vesting: rm support for SDK vesting account types #666

Merged
merged 9 commits into from
Jun 10, 2022
Merged

vesting: rm support for SDK vesting account types #666

merged 9 commits into from
Jun 10, 2022

Conversation

fedekunze
Copy link
Contributor

Description

Closes: #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@github-actions github-actions bot added the CLI label Jun 9, 2022
@fedekunze fedekunze marked this pull request as ready for review June 9, 2022 16:27
danburck
danburck approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@fedekunze fedekunze enabled auto-merge (squash) June 10, 2022 09:20
@fedekunze fedekunze merged commit bc7d61e into main Jun 10, 2022
@fedekunze fedekunze deleted the fedekunze/rm-sdk-vesting branch June 10, 2022 10:11
@fedekunze fedekunze mentioned this pull request Jun 10, 2022
Closed
4 tasks
@danburck danburck mentioned this pull request Jun 10, 2022
Closed
danburck pushed a commit that referenced this pull request Jun 10, 2022
@fedekunze @danburck
vesting: rm support for SDK vesting account types (#666)
7e369be 
* vesting: rm support for SDK vesting account types

* changelog

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danburck danburck danburck approved these changes

@ramacarlucho ramacarlucho Awaiting requested review from ramacarlucho

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fedekunze @danburck