Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit(fees): fees module api audit #691

Merged
merged 9 commits into from
Jun 15, 2022
Merged

audit(fees): fees module api audit #691

merged 9 commits into from
Jun 15, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Jun 15, 2022

Description

This PR includes changes from auditing the x/fees module apis:

  • audit(fees): remove unused validatorShares parameter
  • audit(fees): change wording "DevFeeInfo" -> "Fee"
  • audit(fees): change wording "FeesInverse" -> "DeployerFees"
  • audit(fees): refactor types methods signature
  • fix formatting

Also closes ENG-273: https://linear.app/evmos/issue/ENG-273/xfees-module-renaming-requests

@linear
Copy link

linear bot commented Jun 15, 2022

ENG-449 API audit

@linear
Copy link

linear bot commented Jun 15, 2022

ENG-273 x/fees module renaming requests

Tracking naming changes in the fees module.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #691 (46cf9c6) into main (bc9651c) will decrease coverage by 0.00%.
The diff coverage is 94.44%.

❗ Current head 46cf9c6 differs from pull request most recent head 24d518f. Consider uploading reports for the commit 24d518f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.01%     
==========================================
  Files         122      122              
  Lines        6943     6956      +13     
==========================================
+ Hits         5686     5696      +10     
- Misses       1120     1123       +3     
  Partials      137      137              
Impacted Files Coverage Δ
x/fees/types/keys.go 0.00% <0.00%> (ø)
x/fees/types/params.go 94.64% <ø> (-0.75%) ⬇️
app/upgrades/v5/upgrades.go 56.33% <85.71%> (+5.09%) ⬆️
x/fees/keeper/fees.go 98.24% <96.00%> (ø)
app/app.go 85.00% <100.00%> (+0.02%) ⬆️
x/fees/keeper/grpc_query.go 94.00% <100.00%> (ø)
x/fees/keeper/msg_server.go 94.82% <100.00%> (ø)
x/fees/types/codec.go 100.00% <100.00%> (ø)
x/fees/types/fee.go 100.00% <100.00%> (ø)
x/fees/types/genesis.go 100.00% <100.00%> (ø)
... and 1 more

@danburck danburck changed the title ENG 449 fees api audit audit(fees): fees module api audit Jun 15, 2022
@danburck danburck marked this pull request as ready for review June 15, 2022 15:30
x/fees/types/fee.go Outdated Show resolved Hide resolved
@danburck danburck enabled auto-merge (squash) June 15, 2022 16:34
@danburck danburck merged commit 976439a into main Jun 15, 2022
@danburck danburck deleted the ENG-449-fees-api-audit branch June 15, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants