Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration(testnet): add v7 migration for moving inacessible faucet address #760

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Jul 11, 2022

@danburck danburck marked this pull request as ready for review July 11, 2022 14:51
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #760 (72cdbc3) into main (0748677) will decrease coverage by 0.17%.
The diff coverage is 44.11%.

❗ Current head 72cdbc3 differs from pull request most recent head f261fae. Consider uploading reports for the commit f261fae to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   81.47%   81.30%   -0.18%     
==========================================
  Files         125      126       +1     
  Lines        7159     7193      +34     
==========================================
+ Hits         5833     5848      +15     
- Misses       1187     1204      +17     
- Partials      139      141       +2     
Impacted Files Coverage Δ
app/upgrades/v6/upgrades.go 11.90% <ø> (ø)
app/upgrades/v7/upgrades.go 25.00% <25.00%> (ø)
app/app.go 85.28% <90.00%> (+0.06%) ⬆️

app/upgrades/v7/upgrades_test.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) July 11, 2022 15:01
@fedekunze fedekunze merged commit 4c95e71 into main Jul 11, 2022
@fedekunze fedekunze deleted the ENG-151-migrate-inaccessible-balance branch July 11, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants