Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add amino codec to feeSplit #859

Merged
merged 4 commits into from
Aug 24, 2022

Conversation

hanchon
Copy link
Contributor

@hanchon hanchon commented Aug 23, 2022

Description

Without the amino codec registered we can not send EIP712 transactions, error on submit:

  tx_response: {
    height: '0',
    txhash: '2D17346A4DEEBE9ADA74A06F328DA69BBCC8907623FC910C9D8E9C00AC1FC34D',
    codespace: 'sdk',
    code: 4,
    data: '',
    raw_log: 'signature verification failed; please verify account number (11) and chain-id (evmos_9000-1): failed to pack and hash typedData primary type: there is extra data provided in the message (2 < 4) [evmos/ethermint@v0.19.0/ethereum/eip712/eip712.go:34]: unauthorized',
    logs: [],
    info: '',
    gas_wanted: '3000000',
    gas_used: '84492',
    tx: null,
    timestamp: '',
    events: []
  }
}

Closes: #XXX


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@linear
Copy link

linear bot commented Aug 23, 2022

ENG-708 Register Amino codec for feeSplit

Without the amino codec registered, sending a transaction will return:

{
  tx_response: {
    height: '0',
    txhash: '7DC4801161CC1B7CEE86F1BE95FA8105BE3010195409ED76F08E5A30959DDA23',
    codespace: 'sdk',
    code: 2,
    data: '',
    raw_log: 'unable to resolve type URL /feesplit.v1.MsgRegisterFeeSplit: tx parse error',
    logs: [],
    info: '',
    gas_wanted: '0',
    gas_used: '6684',
    tx: null,
    timestamp: '',
    events: []
  }
}

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #859 (b82aab2) into main (4446bcd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
+ Coverage   81.06%   81.07%   +0.01%     
==========================================
  Files         127      127              
  Lines        7244     7251       +7     
==========================================
+ Hits         5872     5879       +7     
  Misses       1231     1231              
  Partials      141      141              
Impacted Files Coverage Δ
x/feesplit/types/codec.go 100.00% <100.00%> (ø)
x/feesplit/types/msg.go 100.00% <100.00%> (ø)

@hanchon hanchon marked this pull request as ready for review August 23, 2022 16:57
@fedekunze fedekunze merged commit 5a7d7d0 into main Aug 24, 2022
@fedekunze fedekunze deleted the hanchon/eng-708-register-amino-codec-for-feesplit branch August 24, 2022 08:30
facs95 pushed a commit that referenced this pull request Aug 29, 2022
* feat: add amino codec to feeSplit

* fix: register amino, use aminocdc for SignBytes

* chore: update changelog

* fix: change comment to use feesplit
facs95 pushed a commit that referenced this pull request Aug 29, 2022
* feat: add amino codec to feeSplit

* fix: register amino, use aminocdc for SignBytes

* chore: update changelog

* fix: change comment to use feesplit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants