-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add amino codec to feeSplit #859
Merged
fedekunze
merged 4 commits into
main
from
hanchon/eng-708-register-amino-codec-for-feesplit
Aug 24, 2022
Merged
feat: add amino codec to feeSplit #859
fedekunze
merged 4 commits into
main
from
hanchon/eng-708-register-amino-codec-for-feesplit
Aug 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-708 Register Amino codec for feeSplit
Without the amino codec registered, sending a transaction will return:
|
Codecov Report
@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 81.06% 81.07% +0.01%
==========================================
Files 127 127
Lines 7244 7251 +7
==========================================
+ Hits 5872 5879 +7
Misses 1231 1231
Partials 141 141
|
fedekunze
approved these changes
Aug 24, 2022
facs95
pushed a commit
that referenced
this pull request
Aug 29, 2022
* feat: add amino codec to feeSplit * fix: register amino, use aminocdc for SignBytes * chore: update changelog * fix: change comment to use feesplit
facs95
pushed a commit
that referenced
this pull request
Aug 29, 2022
* feat: add amino codec to feeSplit * fix: register amino, use aminocdc for SignBytes * chore: update changelog * fix: change comment to use feesplit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without the amino codec registered we can not send EIP712 transactions, error on submit:
Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...