-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(erc20): support registering multiple assets #914
Conversation
ENG-774 Support registering multiple denominations for ERC20s and Coins
Projects such as IBC bridges (Axelar, Gravity) or projects that have multiple coins (Osmosis, Regen eco-credits, etc) would like to register multiple tokens at once either as ERC20s or SDK Coins. Unfortunately, that is not supported at the moment and they need to create a single proposal for each denomination. Scope:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
- Coverage 81.32% 76.62% -4.71%
==========================================
Files 126 131 +5
Lines 7188 7751 +563
==========================================
+ Hits 5846 5939 +93
- Misses 1196 1665 +469
- Partials 146 147 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fedekunze nice implementation.
Will need to try the cli still and waiting for the full tests with several including batch registrations.
Can you also adjust the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking over this @danburck!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job guys!! Left a few comments! 🚀
…vmos/evmos into fedekunze/erc20-multi-register
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved with minor comments
@fedekunze I separated the test suite refactor into this ticket |
Description
Closes: ENG-774
Context
Projects such as IBC bridges (Axelar, Gravity) or projects that have multiple coins (Osmosis, Regen eco-credits, etc) would like to register multiple tokens at once either as ERC20s or SDK Coins. Unfortunately, that is not supported at the moment and they need to create a single proposal for each denomination