Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gogoproto.customname to name EnableEVMHook parameter #99

Merged
merged 5 commits into from
Nov 18, 2021

Conversation

danburck
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #99 (b8011aa) into main (62b8f10) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b8011aa differs from pull request most recent head 7db9971. Consider uploading reports for the commit 7db9971 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          22       22           
  Lines        1610     1610           
=======================================
  Hits         1199     1199           
  Misses        354      354           
  Partials       57       57           
Impacted Files Coverage Δ
app/app.go 82.70% <100.00%> (ø)
x/intrarelayer/keeper/msg_server.go 79.21% <100.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add API breaking change entry on the Changelog?

@danburck danburck changed the title Change use gogoproto.customname for EnableEVMHook param Use gogoproto.customname to name EnableEVMHook parameter Nov 18, 2021
@fedekunze fedekunze merged commit d925959 into main Nov 18, 2021
@fedekunze fedekunze deleted the fix-evm-hook-param-name branch November 18, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants