Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iqlusion gen tx #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Iqlusion gen tx #177

wants to merge 1 commit into from

Conversation

zmanian
Copy link

@zmanian zmanian commented Feb 28, 2022

No description provided.

@tony-iqlusion
Copy link

We're getting the following error trying to use legacy amino multisignatures with our Ledger-based custody setup:

panic: unrecognized/unsupported public key type: *secp256k1.PubKey: invalid pubkey

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/x/genutil.DeliverGenTxs({{0x24661c8, 0xc0000600f0}, {0x2497900, 0xc001908b80}, {{0x0, 0x0}, {0xc001954[88](https://github.com/evmychan/something-special/runs/5353245070?check_suite_focus=true#step:8:88)0, 0xc}, 0x0, {0x0, ...}, ...}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/genutil/gentx.go:113 +0x274
github.com/cosmos/cosmos-sdk/x/genutil.InitGenesis(...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/genutil/genesis.go:18
github.com/cosmos/cosmos-sdk/x/genutil.AppModule.InitGenesis({{}, {_, _}, {_, _}, _, {_, _}}, {{0x24661c8, 0xc0000600f0}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/genutil/module.go:99 +0x15e
github.com/cosmos/cosmos-sdk/types/module.(*Manager).InitGenesis(_, {{0x24661c8, 0xc0000600f0}, {0x2497[90](https://github.com/evmychan/something-special/runs/5353245070?check_suite_focus=true#step:8:90)0, 0xc001908b80}, {{0x0, 0x0}, {0xc001954880, 0xc}, 0x0, ...}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/types/module/module.go:320 +0x29d
github.com/tharsis/evmos/app.(*Evmos).InitChainer(_, {{0x24661c8, 0xc0000600f0}, {0x2497900, 0xc001908b80}, {{0x0, 0x0}, {0xc001954880, 0xc}, 0x0, ...}, ...}, ...)
	github.com/tharsis/evmos/app/app.go:763 +0x1f2

Unfortunately to our knowledge there is not a Ledger app which supports the new Protobuf-based signature format.

I'm not sure if this was removed from Tendermint itself, or if you need additional logic to support it, but it's worked with every other chain we validate on.

@tony-iqlusion
Copy link

tony-iqlusion commented Feb 28, 2022

Curiously, this guide makes it look as if it should work: https://github.com/tharsis/evmos/blob/23a445a/docs/guides/keys-wallets/multisig.md#step-4-create-multisignature

@evmychan
Copy link
Owner

@tony-iqlusion that guide was probably written back when secp-generated addrs were supported. This is no longer the case.

@tony-iqlusion
Copy link

So it seems we're not going to be able to use the original account address we provided because it's using secp256k1.PubKey Ledger keys.

We are looking into either signing an EIP712 message with a Ledger or attempting to move to a software-backed multisig account. Is it OK that the address will no longer match what we originally provided?

@tony-iqlusion
Copy link

Alternatively, if it seems like EIP712 + Ledger + multisig will be supported in the near future, perhaps we could create our validator some time after genesis when it is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants