Click outside menu #162
Closed
Click outside menu #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after updating side menu frame was added.
… after updating side menu frame was added.
…ftSideMenu into clickOutsideMenu
evnaz
reviewed
Aug 12, 2017
| @@ -193,34 +197,43 @@ open class ENSideMenu : NSObject, UIGestureRecognizerDelegate { | |||
| sourceView.addGestureRecognizer(leftSwipeGestureRecognizer) | |||
| } | |||
|
|
|||
| if clickOutsideClose == true { | |||
There was a problem hiding this comment.
Why clickOutsideClose is needed if it's always true?
There was a problem hiding this comment.
Proper design would be if the value is passed in to the initializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I added some changes to the PR #160
I want that my changes will be applied. Looks like developer who created original PR doesn't want to continue his work. So, I created own.
I have added changes that were requested. Will be happy to be usable for project 😄
With regards, Dmytro