Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticCountryZoneRepository doesn't rely on database abstraction #13

Closed
InvisibleKind opened this issue Jun 14, 2016 · 4 comments
Closed

Comments

@InvisibleKind
Copy link
Contributor

This is a copy-paste of removed issue form TYPO3 Forge.

For some reason Evoweb\SfRegister\Domain\Repository\StaticCountryZoneRepository makes such a call:

$query->statement('SELECT * FROM static_country_zones WHERE zn_country_iso_2 = ? AND deleted = 0', array($iso2));

While same can be achieved by:

$query->matching($query->equals('zn_country_iso_2', $iso2));

Also since TYPO3 7.2 there is a bug #67375, which is related to using placeholders in statement() call. So, it is another good reason to change that line.

@garbast
Copy link
Collaborator

garbast commented Jun 14, 2016

Feel free to hand in a pull request

InvisibleKind pushed a commit to InvisibleKind/sf_register that referenced this issue Jun 14, 2016
(implemented at 'master' via commit 1b9fc80)
Relates-to: evoWeb#13
InvisibleKind pushed a commit to InvisibleKind/sf_register that referenced this issue Jun 14, 2016
(implemented at 'master' via commit 1b9fc80)
Relates-to: evoWeb#13
InvisibleKind added a commit to InvisibleKind/sf_register that referenced this issue Jun 14, 2016
(implemented at 'master' via commit 1b9fc80)
Relates-to: evoWeb#13
@InvisibleKind
Copy link
Contributor Author

In fact it is already present in 'master' branch (probably, that's why issue was deleted from Forge), but not in 6.2.x branch, which should be anyway compatible with TYPO3 7.x
Cherry-picking of commit, mentioned in PR, was painful, because lot of things were changed there, so I just changed the line, which brings an error.

@AdvanceWM
Copy link

When I tried applying the bug fix, the form populated, but had no countries in the Country dropdown. TYPO3 7.6.11 and sf_register 6.2.9

@garbast
Copy link
Collaborator

garbast commented Aug 8, 2017

Closed due to inactivity. The merge happend. If there is something else broken please open a new PR.

@garbast garbast closed this as completed Aug 8, 2017
marcusfellinger pushed a commit to marcusfellinger/sf_register that referenced this issue Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants