Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type not found in strict mode #266

Closed
miguelcobain opened this issue Mar 4, 2024 · 0 comments · Fixed by #267
Closed

Type not found in strict mode #266

miguelcobain opened this issue Mar 4, 2024 · 0 comments · Fixed by #267
Labels

Comments

@miguelcobain
Copy link

I'm trying to import the helper in a .gts file and I get the following error:

image

I'm using embroider enabled app, with ember Stable TypeScript Types (using import 'ember-source/types';).

Other than this error in VSCode, everything works correctly. Svg gets rendered correctly and there are no errors/warnings in app build.

chancancode added a commit to chancancode/ember-svg-jar that referenced this issue Mar 6, 2024
With a small change we should be able to make the types we already
have apply to the `./helpers/svg-jar` module.

Not addressed here:

- The types claim the helper to be a class-based helper
- Do we want people to be importing from `./helpers/svg-jar` or do
  we want a re-export
- Do we want to restrict what can be imported via package.json's
  `exports` field

...etc

Basically keeping things working as it is
evoactivity pushed a commit that referenced this issue Mar 6, 2024
With a small change we should be able to make the types we already
have apply to the `./helpers/svg-jar` module.

Not addressed here:

- The types claim the helper to be a class-based helper
- Do we want people to be importing from `./helpers/svg-jar` or do
  we want a re-export
- Do we want to restrict what can be imported via package.json's
  `exports` field

...etc

Basically keeping things working as it is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant